Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart from README #3847

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Update quickstart from README #3847

merged 1 commit into from
Apr 17, 2018

Conversation

ze
Copy link
Contributor

@ze ze commented Mar 25, 2018

This resolves issue #3832.

I'm not sure how well worded "When prompted on GitHub, give access to your account" is as it can come off as too invasive (when it really isn't), but it can be interpreted the other.

@gaborbernat
Copy link
Contributor

@rtfd/core note this PR passes against master, just need to restart the CI.

Copy link
Contributor

@davidfischer davidfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@davidfischer davidfischer merged commit fe2dfe5 into readthedocs:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants