Fix up some of the logic around repo and submodule URLs #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add conditional logic for submodule relative urls * Break down logic a bit more * Add test case for relative url submodule * Broke test case for invalid url submodule Fixes #3857
|
Marked a test xfail for not to not block deploy today. We'll want to create a ticket to resovle |
|
Merging as @humitos and I paired on this and no review happened otherwise. |
humitos
reviewed
Mar 30, 2018
| env=env | ||
| )) | ||
| log.info(check_output(['git', 'add', '.'], env=env)) | ||
| log.info(check_output(['git', 'commit', '-m"Add relative submodule"'], env=env)) | ||
| # Add an invalid submodule URL in the invalidsubmodule branch | ||
| log.info(check_output(['git', 'checkout', '-b', 'invalidsubmodule', 'master'], env=env)) |
There was a problem hiding this comment.
Now this invalidsubmodule is no more invalid.
We probably need to remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3857