Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This fixes two bugs apparent in nesting of translations in subprojects #3909

Merged
merged 2 commits into from
Apr 6, 2018
Merged

This fixes two bugs apparent in nesting of translations in subprojects #3909

merged 2 commits into from
Apr 6, 2018

Commits on Apr 5, 2018

  1. This fixes two bugs apparent in nesting of translations in subprojects 

    The canonical domain was not searching as deep as we support. We support
translations nested in subprojects, and vice versa, this was previously only
searching for translation or subproject, so no nesting at all.

The path was also a similar problem, but instead of a heavy refactor that reused
the canonical domain lookup, I just altered the logic a little here. The pattern
was required to support both superproject as a translation project and
subproject as a translation project.
    @agjohnson
    agjohnson committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    6955226 View commit details
    Browse the repository at this point in the history

  2. Add resolver tests 

    Also lints our test file
    @agjohnson
    agjohnson committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    7addfaf View commit details
    Browse the repository at this point in the history