Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't share state in build task #3946

Merged
merged 2 commits into from
Apr 19, 2018
Merged

Don't share state in build task #3946

merged 2 commits into from
Apr 19, 2018

Commits on Apr 13, 2018

  1. Don't share state in build task 

    Move task steps to an isolated class, instead of possibly sharing state in
between tasks. This bug is not consistently reproduceable, but one consistent
way to reproduce is to drop to ``rdb`` on the UpdateDocsTask run method.
Previously, if you did this while running 2 celery processes, and triggered 2
builds, you could witness state changing on the task instance. By moving state
to a separate class that is instantiated on each task execution, this completely
avoids shared state in these tasks.
    @agjohnson
    agjohnson committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    af2d922 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2018

  1. Add docs

    @agjohnson
    agjohnson committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    35145ec View commit details
    Browse the repository at this point in the history