Use the latest theme version in the default builder #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2018
| @@ -245,7 +245,7 @@ def install_core_requirements(self): | |||
| positive='sphinx<2', | |||
| negative='sphinx==1.7.4', | |||
| ), | |||
| 'sphinx-rtd-theme<0.3', | |||
| 'sphinx-rtd-theme==0.3.1', | |||
There was a problem hiding this comment.
This should not be pinned to a specific version, so we can release & ship new versions. It should likely bump to <0.4.
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will use the latest theme across the whole site unless people are pinned to a specific version. I believe this is sufficiently stable to roll out to a wider audience. While 0.3.0 had a number of issues, the biggest complaint we are seeing in 0.3.1 is the lack of highlighting (surprising since that never worked from the dawn of history until a week ago).
https://sphinx-rtd-theme.readthedocs.io/en/latest/changelog.html#v0-3-1
Fixes #4072
Fixes #4050