Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth/services: don't abuse log.exception #4133

Merged
merged 1 commit into from
May 24, 2018
Merged

oauth/services: don't abuse log.exception #4133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readthedocs/oauth/services/bitbucket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def setup_webhook(self, project):
project,
)
else:
log.exception(
log.error(
'Bitbucket webhook creation failed for project: %s',
project,
)
Expand Down Expand Up @@ -287,7 +287,7 @@ def update_webhook(self, project, integration):
project,
)
else:
log.exception(
log.error(
'Bitbucket webhook update failed for project: %s',
project,
)
Expand Down
4 changes: 2 additions & 2 deletions readthedocs/oauth/services/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def setup_webhook(self, project):
project,
)
else:
log.exception(
log.error(
'GitHub webhook creation failed for project: %s',
project,
)
Expand Down Expand Up @@ -274,7 +274,7 @@ def update_webhook(self, project, integration):
project,
)
else:
log.exception(
log.error(
'GitHub webhook update failed for project: %s',
project,
)
Expand Down
4 changes: 2 additions & 2 deletions readthedocs/oauth/services/gitlab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ def setup_webhook(self, project):
project,
)
else:
log.exception(
log.error(
'GitLab webhook creation failed for project: %s',
project,
)
Expand Down Expand Up @@ -363,7 +363,7 @@ def update_webhook(self, project, integration):
log.exception(
'GitLab webhook update failed for project: %s', project)
else:
log.exception(
log.error(
'GitLab webhook update failed for project: %s',
project,
)
Expand Down