Remove the UID from the GA measurement protocol #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Jul 10, 2018
davidfischer
commented
Jul 17, 2018
| @@ -57,9 +57,6 @@ def anonymize_user_agent(user_agent): | |||
|
|
|||
| def send_to_analytics(data): | |||
| """Sends data to Google Analytics""" | |||
| if data.get('uip') and data.get('ua'): | |||
| data['uid'] = generate_client_id(data['uip'], data['ua']) | |||
There was a problem hiding this comment.
Removing this makes nothing show up in Google Analytics which is even worse. It looks like we want the Client ID (cid).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for a bug in the GA measurement protocol. Specifically it causes events to only show up in real-time reports and not regular reports.
As a result of this workaround, there will be no handling of session data and all users will be treated as "new" as opposed to returning. Another possible workaround is to use the
cidparameter which would involve constructing a deterministic UUID.