[Fix #4407] Port Project Search for Elasticsearch 6.x #4408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavemanguy
approved these changes
Jul 20, 2018
There was a problem hiding this comment.
This looks like a good update. I do wonder if this is useful, or if we should just be dropping users into the main site search with the project filtered. It kinda feels weird to have this search UI which doesn’t support Faceting and filtering. I guess it matches what users get on the doc page search, but you can’t even specify a version to search. I’m thinking maybe we just remove it, unless there is a good reason to keep it?
|
I think its a design decision to remove it. But as we need to deploy our ES changes soon, we should keep it as it is and port it to work with latest code. Later we can discuss about removing it. What do you think? |
|
Sounds good. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed from our intial stage while we port our search infra to Elasticsearch 6.x
Its similar to the File Search that we ported in #4211
Its needed to be merged before we deploy new search to production.
This fixes #4407. @ericholscher r?