Fix for issue #4092: Remove unused field from Project model #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking at this, I think you made this PR with an old version of the repo (that's why the conflicts), do you mind opening a new PR with an updated branch?. Let me know if you need help to do so. |
|
@Alig1493 You should rebase on master and fix the merge conflicts. |
|
@stsewd @safwanrahman I'll look into it. |
|
@stsewd @safwanrahman I've looked into it to the best of my ability. Would you like to take a look into it? |
| model_name='project', | ||
| name='comment_moderation', | ||
| ), | ||
| migrations.AlterField( |
There was a problem hiding this comment.
The rest of alters are from missing migrations (just changes in help text or options) #4201
|
Looks good. r+ |
safwanrahman
approved these changes
Jul 30, 2018
humitos
approved these changes
Aug 15, 2018
|
Bumped the migration name, and will merge this 👍 |
Codecov Report
@@ Coverage Diff @@
## master #4431 +/- ##
==========================================
- Coverage 76.21% 76.21% -0.01%
==========================================
Files 158 158
Lines 10019 10017 -2
Branches 1265 1265
==========================================
- Hits 7636 7634 -2
Misses 2039 2039
Partials 344 344
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4092