Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mailgun from our dependencies #4531

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Remove mailgun from our dependencies #4531

merged 1 commit into from
Aug 17, 2018

Conversation

agjohnson
Copy link
Contributor

This is prod only, and is out of date. This dependency is handled by our
provisioning.

@agjohnson
Remove mailgun from our dependencies
e5c007e 
This is prod only, and is out of date. This dependency is handled by our
provisioning.
@agjohnson agjohnson requested a review from a team August 16, 2018 19:48
@agjohnson agjohnson added Bug A bug Accepted Accepted issue on our roadmap labels Aug 16, 2018
@agjohnson
Copy link
Contributor Author

In theory, we should probably just be moving all of deploy.txt out of our repo.

@humitos
Copy link
Member

humitos commented Aug 16, 2018

Yeap. This could be a file managed by Salt in our ops repo.

ericholscher
ericholscher approved these changes Aug 17, 2018
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Moving prod to our ops repo makes a lot of sense.

@agjohnson agjohnson merged commit f9965a1 into master Aug 17, 2018
@agjohnson agjohnson deleted the agj/remove-mailgun branch August 17, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agjohnson @humitos @ericholscher