Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase footer ad text size #4678

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Conversation

davidfischer
Copy link
Contributor

#4628 shrank the size marginally of footer ads and now I think they are too small. I think the text can safely be the same size as the sidebar ads and most of the rest of the document (14px).

Screenshots

Previously

screen shot 2018-09-28 at 4 13 02 pm

New

screen shot 2018-09-28 at 4 13 59 pm

@davidfischer davidfischer requested a review from a team September 28, 2018 23:15
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed they look too small. 👍

@davidfischer davidfischer merged commit 2d9ca7d into master Oct 1, 2018
@davidfischer davidfischer deleted the davidfischer/footer-ad-text-size branch October 1, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants