Add docstring to DrfJsonSerializer so we know why it's there #4836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hehe, the linting has failed. If you run
You will still need to paraphrase it, because "This" is redundant :D |
|
It seems that we are "more than strict" with the docstring ;) |
ericholscher
force-pushed
the
add-docstring
branch
from
75aae41
to
cffca56
Compare
|
Fixed! |
|
Linting will still fail because of the usage of "This" as the first word of the docstring... |
Codecov Report
@@ Coverage Diff @@
## master #4836 +/- ##
==========================================
- Coverage 76.21% 76.21% -0.01%
==========================================
Files 158 158
Lines 10019 10017 -2
Branches 1265 1265
==========================================
- Hits 7636 7634 -2
Misses 2039 2039
Partials 344 344
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.