Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify users about the usage of deprecated webhooks #4898

Merged
merged 9 commits into from
Jan 11, 2019

Commits on Dec 10, 2018

  1. Notify users about the usage of deprecated webhooks

    Each time a deprecated webhook is hit, a notification is
    created (without duplicating it) to be sent.
    humitos committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    0778294 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ebf278b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ec54cfa View commit details
    Browse the repository at this point in the history
  4. Remove no necessary settings

    humitos committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    095607b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6123d45 View commit details
    Browse the repository at this point in the history
  6. Better docstring

    humitos committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    ecb1f8d View commit details
    Browse the repository at this point in the history
  7. Lint

    humitos committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    8a6bb8a View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2019

  1. Update copy on notifications for github services deprecation (#5067)

    * Updated copy on webhooks
    
    * Drop "deprecated webhook endpoint" copy, this is core team nomenclature, not user
    nomenclature.
    * Add small amount of docs to point to
    
    * Update docs and point to docs in notification message
    
    * Add year
    agjohnson authored Jan 8, 2019
    Configuration menu
    Copy the full SHA
    fb4bd86 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2019

  1. Split up deprecated view notification to GitHub and other webhook end…

    …points (#5083)
    
    * Updated copy on webhooks
    
    * Drop "deprecated webhook endpoint" copy, this is core team nomenclature, not user
    nomenclature.
    * Add small amount of docs to point to
    
    * Update docs and point to docs in notification message
    
    * Split up deprecated view notification to GitHub and other webhook endpoints
    
    This sets a date for deprecated of these endpoints as Mar 1st 2019. Too
    soon?
    
    * Reduce complexity and drop decorator pattern for Notification
      classmethod pattern used in other notifications
    * Add notifications for non-GitHub incoming webhooks
    * Add docs as well
    
    * More renaming and slight refactor
    
    Found out 2x messages are being generated, so this stops the automated
    mechanism for triggering these messages.
    
    * Update dates
    
    * Also update docs
    
    * Typo on date
    
    * Back out some more of the changes to notifications to make them operable without automation
    
    * Add admin method for notification
    
    * Add admin filter for project features
    agjohnson authored Jan 10, 2019
    Configuration menu
    Copy the full SHA
    2e243c4 View commit details
    Browse the repository at this point in the history