Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add admin functions for wiping a version #5140

Merged
merged 11 commits into from
Feb 26, 2019
Merged

Add admin functions for wiping a version #5140

merged 11 commits into from
Feb 26, 2019

Conversation

dojutsu-user
Copy link
Member

Closes #3684

@agjohnson agjohnson added this to the Site admin features milestone Jan 22, 2019
ericholscher
ericholscher requested changes Jan 29, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this breaks in testing.
screenshot 2019-01-29 17 00 40

readthedocs/core/utils/general.py Outdated

def wipe_version_via_slug(version_slug):
"""Wipes the given version."""
version = get_object_or_404(Version, slug=version_slug)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be filtering by a project, not just a version slug.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.
I have pushed the changes.

@dojutsu-user
Copy link
Member Author

dojutsu-user commented Jan 30, 2019 •
edited
Loading

@ericholscher
I have pushed the changes suggested by you.

@dojutsu-user
Copy link
Member Author

@ericholscher
I have added one more test.
Can this PR get another round of review?

ericholscher
ericholscher approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@ericholscher
Copy link
Member

Thanks!

@ericholscher ericholscher merged commit bba018d into readthedocs:master Feb 26, 2019
@dojutsu-user dojutsu-user deleted the admin-action-for-version branch February 26, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Site admin features
Development

Successfully merging this pull request may close these issues.
3 participants
@dojutsu-user @ericholscher @agjohnson