Remove logic for guessing slug from an unregistered domain #5143
Conversation
|
We can remove the |
|
I think this is ready to go, but I think we need to do a bit more work to reduce the possible downsides. We have some manual migration steps, but any project that is missed will randomly have their Domain stop working. This is not a great experience, so I think we should:
|
| please review our <a href="{{ docsurl }}">custom domain documentation</a>. | ||
| In the past, we allowed custom domains to point to us without configuring the domain in the Read the Docs dashboard | ||
| and we attempted to intelligently guess the correct project. | ||
| This was never explicitly supported and documented. It just happened to work. |
There was a problem hiding this comment.
Believe it used to be documented.
There was a problem hiding this comment.
I can update that then
We have logs over the last 3 months. I added the domain where the following were true:
|
|
Going to fix the tests |
| <p> | ||
| {% with docsurl='https://docs.readthedocs.io/en/stable/custom_domains.html' %} | ||
| {% blocktrans trimmed %} | ||
| If you control this domain and believe this is in error, |
There was a problem hiding this comment.
Shouldn't be is an error?
| If you control this domain and believe this is in error, | |
| If you control this domain and believe this is an error, |
There was a problem hiding this comment.
Either works but I think yours is better.
There was a problem hiding this comment.
Interesting, I guess is used more in other areas?
I messed up #4730 trying to solve the conflicts. See the another PR for the discussion (sorry!)
Close #1991