Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version references to :latest tag #5245

Merged
merged 3 commits into from
Feb 12, 2019

Conversation

gorshunovr
Copy link
Contributor

@gorshunovr gorshunovr commented Feb 6, 2019

Changed version references to :latest tag and linked containers repository for details on software installed into the containers used for documentation builds.

Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we definitely should update this docs. But we are using latest (4.0) as default image now

docs/builds.rst Outdated Show resolved Hide resolved
docs/builds.rst Outdated
* ``textlive-full``

`More details <https://github.com/rtfd/readthedocs-docker-images/blob/releases/3.x/Dockerfile>`__
More details on software installed in images could be found in `rtfd/readthedocs-docker-images <https://github.com/rtfd/readthedocs-docker-images>`__ repository by browsing specific tag, marked in README as ``stable``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't find a way to automate this, but is also a hard to read the docker file to see all the libs that are installed, maybe we should update to match the libs from latest (4.0) and stable (3.0)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's harder to maintain a list by copy-pasting it on every release. Dockerfile is pretty self-explanatory and easy to read: you even have one lib per line. I would leave this reference to the repository.

@gorshunovr gorshunovr changed the title Change version references to :stable tag Change version references to :latest tag Feb 6, 2019
@gorshunovr
Copy link
Contributor Author

gorshunovr commented Feb 6, 2019

PR title and text have been changed to adjust to the updated label.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change.

@ericholscher ericholscher merged commit 911d80b into readthedocs:master Feb 12, 2019
@ericholscher
Copy link
Member

Thanks!

@gorshunovr gorshunovr deleted the patch-1 branch May 15, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants