Don’t delay search delete on project delete #5262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing an issue where we were trying to delete a project that didn’t exist, so it wasn’t getting removed from the index properly. It should be done in process, otherwise it’s a race condition.
humitos
approved these changes
Feb 11, 2019
There was a problem hiding this comment.
Makes sense to me considering that we are already inside a task and how the query is performed inside delete_objects_in_es.
In other simpler cases, we were passing everything that it's needed for the task as arguments to avoid querying the db for a non-existent object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing an issue where we were trying to delete a project that didn’t exist, so it wasn’t getting removed from the index properly. It should be done in process, otherwise it’s a race condition.