Increase path's max_length for ImportedFile model to 4096 #5345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dojutsu-user
changed the title
| @@ -1089,7 +1089,7 @@ class ImportedFile(models.Model): | |||
| ) | |||
| name = models.CharField(_('Name'), max_length=255) | |||
There was a problem hiding this comment.
Believe we want to update the name as well.
There was a problem hiding this comment.
What should be the optimal value for max_length. I didn't find that in the discussion of #5061
There was a problem hiding this comment.
Name only saves the filename not the full path with directories, so the limitation for filenames is only 255, so we are safe.
stsewd
reviewed
Feb 26, 2019
| @@ -1089,7 +1089,7 @@ class ImportedFile(models.Model): | |||
| ) | |||
| name = models.CharField(_('Name'), max_length=255) | |||
| slug = models.SlugField(_('Slug')) | |||
| path = models.CharField(_('Path'), max_length=255) | |||
| path = models.CharField(_('Path'), max_length=4096) | |||
There was a problem hiding this comment.
We should add a comment why 4096 is our magic number here
There was a problem hiding this comment.
Thank you.
I have added the comment and pushed the changes.
ericholscher
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5061