Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relative paths in config module #5377

Merged
merged 4 commits into from
May 20, 2019
Merged

Use relative paths in config module #5377

merged 4 commits into from
May 20, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Mar 1, 2019

Closes #5364

The main change was in readthedocs/config/validation.py, we are really good covered with tests here, and tested it locally, everything keeps working.

@stsewd stsewd requested a review from a team March 1, 2019 00:40
@ericholscher
Copy link
Member

ericholscher commented Mar 1, 2019 •
edited
Loading

What is the goal of doing this?

Edit: Ignore me -- I just read the linked ticket.

@stale
Copy link

stale bot commented Apr 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Apr 15, 2019
@stsewd stsewd removed the Status: stale Issue will be considered inactive soon label Apr 15, 2019
humitos
humitos approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@humitos humitos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We should merge and ship it :)

Are we using this data stored in the _config field from the Build for something? I see that we will have two different PATHs now in the DB for this field --will this affect our code?

@stsewd stsewd merged commit 49995aa into readthedocs:master May 20, 2019
@stsewd stsewd deleted the use-relative-paths-in-config-module branch May 20, 2019 16:28
@stsewd
Copy link
Member Author

stsewd commented May 20, 2019

Are we using this data stored in the _config field from the Build for something?

No really, but we are going to use it to show that info to the user in each build, so they don't need the builder path neither.

stsewd added a commit to stsewd/readthedocs.org that referenced this pull request May 31, 2019
@stsewd
Fix mkdocs relpath
806ad3b 
After readthedocs#5377
The code calling the config module is in charge of getting the full
path.
@stsewd stsewd mentioned this pull request May 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save relative paths from the config module
3 participants
@stsewd @ericholscher @humitos