Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reraise of exception #5423

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Fix reraise of exception #5423

merged 1 commit into from
Mar 14, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Mar 8, 2019

We were hiding the real error
from the user

Related #4745 (comment)

@stsewd
Fix reraise of exception
32c2386 
We were hiding the real error
from the user

Related readthedocs#4745 (comment)
@stsewd stsewd requested a review from a team March 8, 2019 01:03
ericholscher
ericholscher approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand what this was doing before. It looks like we don't use this with_traceback pattern anywhere else, so seems good to remove it.

@ericholscher ericholscher merged commit 61db3c1 into readthedocs:master Mar 14, 2019
@stsewd stsewd deleted the fix-exception-configpy-not-found branch March 14, 2019 15:27
@stsewd
Copy link
Member Author

stsewd commented Mar 14, 2019

We were catching a general ProjectConfigurationError execption and re-raising the error with a different message but with the same type 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @ericholscher