Regroup settings #5459
Regroup settings #5459
Conversation
This is an initial proposal for readthedocs#5413
|
This is how it looks like
|
There was a problem hiding this comment.
I'm +1 on moving documentation_type to advanced as I do think that's a configuration option that few people need to change. It also can be configured in the YAML file.
I think the order is pretty good (I made 1 comment there).
I'm also +1 on crispy forms overall.
| 'default_version', | ||
| 'default_branch', | ||
| 'privacy_level', | ||
| 'analytics_code', |
There was a problem hiding this comment.
This comment is outside the scope of this PR, but we could put this setting into the config file on a per-version basis. It might be nice to get that information versioned.
There was a problem hiding this comment.
Any per-version config, is excellent for the YAML. I agree with David to implement this in another PR.
There was a problem hiding this comment.
Don't people use just one analytics code per site? And also, isn't a way of identify each page from analytics?
|
It can be in a separate PR and it would be a lot easier if we had crispy forms but I think we do need to have a note in here to the effect of "These settings can be configured in your project's configuration file and settings in the configuration file override the settings listed here". |
This is an initial proposal for #5413
This only affects the order of the current settings, we can create real groups modifying the template, using two forms or using https://django-crispy-forms.readthedocs.io/en/latest/layouts.html
For now, I would like to get reviewed the order/group of these options, and if someone has an opinion about the best way of having separate groups using the adobe suggestions.