-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Django Debug Toolbar in development #5464
Conversation
@@ -95,3 +95,6 @@ django-cors-middleware==1.3.1 | |||
|
|||
# User agent parsing - used for analytics purposes | |||
user-agents<1.2.0 | |||
|
|||
# Required only in development and linting | |||
django-debug-toolbar==1.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should put this in another file like https://github.com/stsewd/readthedocs.org/blob/b856e791b6be6cff68a98efd1422f30136c2d856/requirements/testing.txt#L27-L29? Mostly because this will be installed in production too, we are not going to activate it, but looks like a dead package to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I put it here is that it is required for testing, development, and linting. Currently only the default requirements.txt
file (which then loads pip.txt
) is used in development according to our documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comment can be addressed in another PR if considered, I'll like to try this now :)
I'm going to merge this now, but I think @stsewd's comment is a fair one. Overall, I think we need to be very clear what each of our requirements files are for. We also might have 1-2 too many requirements files (maybe just dev, test, and prod?). These are issues for another PR though. |
In the past few days I have found a few performance issues that could have been caught easier with Django Debug Toolbar (#5451 and #5460). I propose we enable it in development.