Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta descriptions to top documentation #5593

Merged
merged 3 commits into from
Apr 15, 2019

Conversation

davidfischer
Copy link
Contributor

Initially my goal here is to just have slightly better blurbs on search engine result pages (SERPs).

Screen Shot 2019-04-15 at 11 41 09 AM

Screen Shot 2019-04-15 at 11 42 02 AM

@davidfischer davidfischer requested a review from a team April 15, 2019 15:43
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@@ -1,6 +1,10 @@
Importing Your Documentation
============================

.. meta::
:description lang=en: Import your existing technical documentation from source control into Read the Docs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should choose "source control" or "version control" -- we should pick one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version control is probably better and I changed it to that one. The one positive of source control is that it doesn't overload the term "version" which RTD uses.

Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Eric's comment about version control.

@davidfischer davidfischer merged commit d4d1b5d into master Apr 15, 2019
@davidfischer davidfischer deleted the davidfischer/docs-meta-descriptions branch April 15, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants