Notify the user when deleting a superproject #5596
Conversation
|
@stsewd Also, I have updated the code. |
| @@ -6,6 +6,11 @@ | |||
| {% block content-header %}<h1>{% blocktrans with project.name as name %}Delete {{ name }}?{% endblocktrans %}</h1>{% endblock %} | |||
|
|
|||
| {% block content %} | |||
|
|
|||
| {% if is_superproject %} | |||
| <p>This project has subprojects under it. Deleting this will make them as regular projects. This will effect the URLs of the subprojects and they will be served normally as other projects.</p> | |||
There was a problem hiding this comment.
We should put a link to the subprojects page here has subprojects...
Also, the paragraph needs to be marked for translation
| 'This project <a href="/dashboard/pip/subprojects/">has subprojects</a> under it. ' | ||
| 'Deleting this will make them as regular projects. ' | ||
| 'This will effect the URLs of the subprojects and they will be served normally as other projects.', | ||
| ' '.join(resp_content.split()) # this is done to remove all escapte sequences and new lines characters. |
There was a problem hiding this comment.
I think you can avoid this by using the trimmed option in the blocktrans
There was a problem hiding this comment.
Thank you.
I have updated the PR.
|
|
||
| response = self.client.get('/dashboard/pip/delete/') | ||
| self.assertEqual(response.status_code, 200) | ||
| self.assertIn( |
There was a problem hiding this comment.
assertContains is a shorcut for this https://docs.djangoproject.com/en/2.2/topics/testing/tools/#django.test.SimpleTestCase.assertContains
There was a problem hiding this comment.
Thank you.
This was a nice shortcut.
I have updated the PR.
There was a problem hiding this comment.
status code is also checked by assertContains ;)
There was a problem hiding this comment.
Default is already 200.
Should we write it here explictly?
Mention that all the subproject's URLs will break.
|
OK. I tried to do a change suggestion and I did it wrong and a proper commit was created. I updated the copy on the test as well. I think this is ready to be merged. @stsewd do you agree? |
Closes #3742