Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Environmental Variable character limit #5597

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Update Environmental Variable character limit #5597

merged 2 commits into from
Apr 17, 2019

Conversation

saadmk11
Copy link
Member

closes #5265

stsewd
stsewd reviewed Apr 16, 2019
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a name to the migration https://docs.djangoproject.com/en/2.2/ref/django-admin/#cmdoption-makemigrations-name

@saadmk11
Copy link
Member Author

@stsewd Updated the PR

ericholscher
ericholscher approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍

@ericholscher ericholscher merged commit a992ad1 into readthedocs:master Apr 17, 2019
@saadmk11 saadmk11 deleted the env-value-update branch April 17, 2019 18:25
kenj115188
kenj115188 reviewed Apr 18, 2019
View reviewed changes
Copy link

@kenj115188 kenj115188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd left review comments

@kenj115188 kenj115188 kenj115188 left review comments

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environmental Variable character limit is 256
4 participants
@saadmk11 @ericholscher @stsewd @kenj115188