Remove ProxyMiddleware #5607
Remove ProxyMiddleware #5607
Conversation
readthedocs/analytics/utils.py
Outdated
|
|
||
| return ip_address | ||
| return None |
There was a problem hiding this comment.
There's two cases here and these changes neglect one of them:
- If
X-Forwarded-Foris present, this function should return the first value from the comma separated list. Arguably, it could validate that it is a real IP address, but that isn't that important. - If
X-Forwarded-Foris not present, this function should return the value fromREMOTE_ADDR. This implementation returnsNone.
This function is used in advertising code for geo-targeting as well as being used for server side analytics (currently used in advertising but in the future might replace Google Analytics JS) but the middleware can be safely removed.
There was a problem hiding this comment.
@davidfischer
Thank you for the information.
I have updated the PR.
Will there be any case in which both of these headers are not found? Currently the implementation returns None in that case.
| if x_forwarded_for: | ||
| ip_address = x_forwarded_for.rsplit(':')[0] |
There was a problem hiding this comment.
This logic was removed and also shouldn't be. The X-Forwarded-For header is not exactly a standard but some implementations include a port number. This line strips that port number.
This function is correct and working as-is. Is there a reason to change it? I do appreciate comments which capture the reasoning though.
There was a problem hiding this comment.
The X-Forwarded-For header is not exactly a standard but some implementations include a port number.
Thank you for this information. I didn't found this while searching about the header and removed this line thinking that it can produce bugs.
I have updated the code.
Is there a reason to change it?
The only reason was the readability and to improve comments.
There was a problem hiding this comment.
We should add tests for this also.
There was a problem hiding this comment.
@ericholscher
I have added the tests.
Closes #5605