Gold project sponsorship changes

readthedocs/gold/models.py

@@ -2,9 +2,11 @@
 
 """Django models for recurring donations aka Gold Membership."""
 import math
+from datetime import datetime
 
 from django.db import models
 from django.utils.translation import ugettext_lazy as _
+import pytz
 
 from readthedocs.projects.models import Project
 
@@ -27,6 +29,9 @@ class GoldUser(models.Model):
 
     """A user subscription for gold membership."""
 
+    # Gold members created after this date can no longer sponsor projects to be ad-free
+    SPONSOR_PROJECT_CUTOFF = pytz.utc.localize(datetime(year=2019, month=5, day=1))
+
     pub_date = models.DateTimeField(_('Publication date'), auto_now_add=True)
     modified_date = models.DateTimeField(_('Modified date'), auto_now=True)
 
@@ -61,3 +66,9 @@ def num_supported_projects(self):
         dollars = int(self.level.split('-')[-1])
         num_projects = int(math.floor(dollars // DOLLARS_PER_PROJECT))
         return num_projects
+
+    def can_sponsor_projects(self):
+        if self.pub_date < self.SPONSOR_PROJECT_CUTOFF or self.projects.exists():
+            return True
+
+        return False

readthedocs/gold/templates/gold/projects.html

@@ -11,6 +11,13 @@
 
 {% block edit_content %}
 
+  <p class="empty">
+    {% blocktrans trimmed %}
+      <strong>Note:</strong> this is a legacy feature.
+      New gold members cannot sponsor projects to be ad-free.
+    {% endblocktrans %}
+  </p>
+
   <p class="help_text">
     {% trans "Choose projects that will have all promos removed, and extra features added to them. You get to pick one for every $5/mo you support Read the Docs with." %}
   </p>
@@ -24,17 +31,16 @@ <h3> {% trans "Existing Projects" %} </h3>
     {% endblocktrans %}
   </p>
 
-    <ul>
-    {% for project in projects %}
-        <li>
-        <a href="{{ project.get_absolute_url }}">
-        {{ project }}
-        </a>
-        (<a href="{% url "gold_projects_remove" project.slug %}">{% trans "Remove" %}</a>)
-        </li>
-    {% endfor %}
-    </ul>
-  </p>
+  <ul>
+  {% for project in projects %}
+      <li>
+      <a href="{{ project.get_absolute_url }}">
+      {{ project }}
+      </a>
+      (<a href="{% url "gold_projects_remove" project.slug %}">{% trans "Remove" %}</a>)
+      </li>
+  {% endfor %}
+  </ul>
 
   <h3>{% trans "Add a project" %}</h3>
   <p>

readthedocs/gold/templates/gold/subscription_detail.html

@@ -54,17 +54,19 @@ <h2>{% trans "Gold Subscription" %}</h2>
       <button>{% trans "Cancel Subscription" %}</button>
     </form>
 
-    <h3>{% trans "Projects" %}</h3>
-    <p class="subscription-projects">
-      {% blocktrans trimmed count projects=golduser.num_supported_projects %}
-        You can adopt one project with your subscription.
-      {% plural %}
-        You can adopt {{ projects }} projects with your subscription.
-      {% endblocktrans %}
-    </p>
+    {% if golduser.can_sponsor_projects %}
+      <h3>{% trans "Projects" %}</h3>
+      <p class="subscription-projects">
+        {% blocktrans trimmed count projects=golduser.num_supported_projects %}
+          You can adopt one project with your subscription.
+        {% plural %}
+          You can adopt {{ projects }} projects with your subscription.
+        {% endblocktrans %}
+      </p>
 
-    <form method="get" action="{% url "gold_projects" %}" class="subscription-projects">
-      <button>{% trans "Select Projects" %}</button>
-    </form>
+      <form method="get" action="{% url "gold_projects" %}" class="subscription-projects">
+        <button>{% trans "Select Projects" %}</button>
+      </form>
+    {% endif %}
   </div>
 {% endblock %}

readthedocs/gold/views.py

@@ -103,6 +103,10 @@ def projects(request):
     gold_user = get_object_or_404(GoldUser, user=request.user)
     gold_projects = gold_user.projects.all()
 
+    if not gold_user.can_sponsor_projects():
+        messages.error(request, _('New gold users are no longer allowed to sponsor projects'))
+        return HttpResponseRedirect(reverse('gold_detail'))
+
     if request.method == 'POST':
         form = GoldProjectForm(
             active_user=request.user,

readthedocs/rtd_tests/tests/test_gold.py

@@ -1,4 +1,6 @@
 # -*- coding: utf-8 -*-
+from datetime import timedelta
+
 from django.test import TestCase
 from django.urls import reverse
 from django_dynamic_fixture import fixture, get
@@ -15,7 +17,12 @@ def setUp(self):
 
         self.project = get(Project, slug='test', users=[fixture(), self.user])
 
-        self.golduser = get(GoldUser, user=self.user, level=LEVEL_CHOICES[0][0])
+        self.golduser = get(
+            GoldUser,
+            user=self.user,
+            level=LEVEL_CHOICES[0][0],
+            pub_date=GoldUser.SPONSOR_PROJECT_CUTOFF - timedelta(days=1),
+        )
 
         self.client.login(username='owner', password='test')
 
@@ -25,6 +32,22 @@ def test_adding_projects(self):
         self.assertEqual(self.golduser.projects.count(), 1)
         self.assertEqual(resp.status_code, 302)
 
+    def test_adding_projects_after_cutoff(self):
+        user = create_user(username='testuser', password='testtest')
+        self.client.login(username='testuser', password='testtest')
+        after_cutoff_golduser = get(
+            GoldUser,
+            user=user,
+            level=LEVEL_CHOICES[0][0],
+            pub_date=GoldUser.SPONSOR_PROJECT_CUTOFF + timedelta(days=1),
+        )
+        self.assertEqual(after_cutoff_golduser.projects.count(), 0)
+
+        # Ensure no gold project is created
+        resp = self.client.post(reverse('gold_projects'), data={'project': 'test'})
+        self.assertEqual(after_cutoff_golduser.projects.count(), 0)
+        self.assertEqual(resp.status_code, 302)
+
     def test_too_many_projects(self):
         self.project2 = get(Project, slug='test2')
 

readthedocs/templates/projects/project_advertising.html

@@ -68,8 +68,8 @@ <h4>{% trans "Opting out" %}</h4>
     <li class="module-item">
       {% blocktrans trimmed %}
         If you have an open source project, and can contribute financially,
-        consider a gold subscription. Gold subscribers can disable ads for
-        projects they author.
+        consider a gold subscription. Gold members have an ad-free
+        experience while using Read the Docs.
       {% endblocktrans %}
 
       <form method="get" action="{% url "gold_subscription" %}">