Move version "Clean" button to details page #5706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of showing the "Clean" button next to a version in the listing, this button is moved to the detail page with an explanation about what it does.
humitos
force-pushed
the
humitos/move-clean-button
branch
from
1a8ea0d
to
9d508a0
Compare
|
As a side note, I think that ending up with a Now, when we update a version from the dashboard we do these all together:
On the other hand, our new automation rules and APIv3 version edit probably does not behaves in the same way. This is outside the scope of this PR, but may worth to consider to unify the behavior when the same action is performed by the user. |
agjohnson
approved these changes
May 29, 2019
| {% if not version.active and version.built %} | ||
| <p class="empty"> | ||
| {% url "project_version_delete_html" project.slug version.slug as version_delete_url %} | ||
| {% blocktrans %} |
There was a problem hiding this comment.
Use trimmed on the blocktrans call to improve the text whitespace handling in gettext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of showing the "Clean" button next to a version in the "Inactive Versions" listing, this button is moved to the detail page with an explanation about what it does.
Changed from,
to,
This change is made because we found that multiple buttons in a row breaks in other languages when translated (because of margin/padding). Also, this button is not shown at all in the corporate site and it should be --but we don't want to show it in the listing.