Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build images in docs #5782

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Update build images in docs #5782

merged 1 commit into from
Jun 11, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jun 11, 2019

No description provided.

@stsewd stsewd requested a review from a team June 11, 2019 02:51
ericholscher
ericholscher approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to do this automatically? I feel like we have to update a lot of places when we bump docker versions. Can we just define them in a constant or something?

@stsewd
Copy link
Member Author

stsewd commented Jun 11, 2019

Right now I changed the values to be stable and latest, so we only need to put url in some place

@stsewd stsewd merged commit 2ea4ef0 into readthedocs:master Jun 11, 2019
@stsewd stsewd deleted the update-docs-build-image branch June 11, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @ericholscher