Update conda at startup #5897
Merged
Update conda at startup #5897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behind a Feature flag, we can decide if we want to update the version of ``conda`` from the system to its latest version available. This allow us to use a new release of ``conda`` that is not released under Miniconda yet, but also to not upgrade the Docker image just because of a new release of Miniconda. (the overhead added is around 60 seconds in total)
humitos
force-pushed
the
humitos/update-conda-startup
branch
from
7d5962b
to
2efd2d2
Compare
ericholscher
reviewed
Jul 9, 2019
|
@ericholscher I'm not sure to follow you. Do you say to just remove the feature flag and enable it by default? If it fails, we revert the commit and continue as we were? |
|
yes, after we test it with the feature flag. |
| ) | ||
| shutil.rmtree(version_path) | ||
|
|
||
| if self.project.has_feature(Feature.UPDATE_CONDA_STARTUP): |
There was a problem hiding this comment.
This should also check if the project is using conda, so we don't run it if the user isn't using conda.
There was a problem hiding this comment.
The code is under the Conda class, not need to add a check here.
stsewd
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behind a Feature flag, we can decide if we want to update the version of
condafrom the system to its latest version available.This allow us to use a new release of
condathat is not released under Miniconda yet, but also to not upgrade the Docker image just because of a new release of Miniconda.(the overhead added is around 60 seconds in total --but they say that the new resolver is way faster... so 🥇 )