Improve the version listview #6224
Conversation
- No more than 100 inactive versions - Filter inactive versions by name
|
I should clarify that the whole "Activate a Version" section only displays for project maintainers just like the previous "Inactive Versions" section it replaces. |
| @@ -104,7 +119,7 @@ <h1>{% trans "Inactive Versions" %}</h1> | |||
|
|
|||
| {% if request.user|is_admin:project %} | |||
| <ul class="module-item-menu"> | |||
| <li><a href="{% url "project_version_detail" project.slug version.slug %}">{% trans "Edit" %}</a></li> | |||
| <li><a href="{% url "project_version_detail" project.slug version.slug %}">{% trans "Edit & Activate" %}</a></li> | |||
There was a problem hiding this comment.
I don't like the "Edit & Activate" label for the button, but I do not have a better one. Do you think that just "Edit" as it was does not communicate it properly?
There was a problem hiding this comment.
I might have the same feeling. The phrase sounds overly specific for a user. Technically, from our perspective, they are editing and activating, but to the user, they are just activating. I think "Activate" is the most correct descriptor for what the user is looking to accomplish, we can gloss over the fact that it drops into a form.
There was a problem hiding this comment.
Sounds good. I'll update it.
There was a problem hiding this comment.
Change looks good 👍 , but I'll block on changing the button text. I'll open up a separate issue to describe the flow I was talking about yesterday but didn't have the bandwidth to delve into more. We landed on this as an intermediate fix, a final fix probably relies on SUI anyways.
|
I changed the text on that button "Edit & Activate" -> "Activate". This should be merge ready. For the fix to take effect on RTD for Business where that template is overridden, I will create a corresponding private PR. |
Update the version listview screen with the following:
Screenshot