Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: guide about reproducible builds #7888
Docs: guide about reproducible builds #7888
Changes from 1 commit
3478c2a
d93b53a
60a6861
a721b23
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, core dependencies can't be pinned in conda environment files at the moment, right? #3829
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried it again to be sure, Sphinx gets overridden https://readthedocs.org/projects/rtd-conda-test/builds/13122163/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can be pinned. However,
CONDA_APPEND_CORE_REQUIREMENTS
feature flag has to be enabled in the project by the core team: https://docs.readthedocs.io/en/stable/guides/feature-flags.html#feature-flagsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, for future build tests, we have this repository https://github.com/readthedocs/test-builds where we have one test case per branch (properly named) with the use case that it's testing described in the homepage/index 😉
(you can create a PR instead of a branch since you don't have permissions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm tempted to add a note about that here, but I think maybe we should push to make that the default.
This file was deleted.