Build: use ubuntu-20.04 image for setup VCS step
#8930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were _always_ using `readthedocs/build:latest` to run all the VCS steps (e.g. `git clone`). That image had an old `ca-certificates` Ubuntu package that does not contains the newer Lets Encrypt certificate and because of that many git command failed. Now, we had rebuilt the `ubuntu-20.04` image which includes a newer version of this package and we are defining this image to be used by default in the setup VCS step. The main goal is to avoid calling `apt-get install ca-certificate` on each build and reduce this overhead.
|
I QAed this locally with |
agjohnson
reviewed
Feb 17, 2022
We need this because there are some attributes that are passed only to DockerBuildEnvironment but are not allowed in LocalBuildEnvironment (e.g. `container_image`). As LocalBuildEnvironment is used in the tests, they were failing because it doesn't accept this argument. Again, we should refactor our test's code to completely remove LocalBuildEnvironment and rely 100% on DockerBuildEnvironment.
|
I updated the code to make the tests pass. |
stsewd
reviewed
Feb 17, 2022
agjohnson
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always using
readthedocs/build:latestto run all the VCS steps (e.g.git clone). That image had an oldca-certificatesUbuntu package that doesnot contains the newer Lets Encrypt certificate and because of that many git
command failed.
Now, we had rebuilt the
ubuntu-20.04image which includes a newer version ofthis package and we are defining this image to be used by default in the setup
VCS step. The main goal is to avoid calling
apt-get install ca-certificateoneach build and reduce this overhead.
Closes #8555