-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ValueError: too many values to unpack (expected 3) #1343
Comments
Confirmed. Occurs on Sphinx
https://github.com/obsproject/obs-studio/actions/runs/3120097770/jobs/5060455218 |
This should be reverted once sphinx_rtd_theme is updated. See readthedocs/sphinx_rtd_theme#1343
I have triaged this issue -- please see https://bugs.funtoo.org/browse/FL-10533 The short summary is that the following line in sphinx_rtd_theme assumes that the sphinx version can be split into 3 parts. This is not true with 5.2.0.post0. The relevant line in the traceback is: File "/usr/lib/python3.7/site-packages/sphinx_rtd_theme/layout.html", line 13, in top-level template code pypi supports different types of versions besides x.y.z. It is best to parse the version using a more robust version parsing such as packaging.version.Version class. |
Sphinx 5.2.0.post0 release has a known compatibility issue with the `sphinx_rtd_theme` (see the issue readthedocs/sphinx_rtd_theme#1343). Revert this commit once this compatibility issue is resolved. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
Readthedocs uses incorrect version parsing, which is not compatible with current sphinx version, see readthedocs/sphinx_rtd_theme#1343. Implemented workaround until this issue is fixed.
Readthedocs uses incorrect version parsing, which is not compatible with current sphinx version, see readthedocs/sphinx_rtd_theme#1343. Implemented workaround until this issue is fixed.
Sphinx 5.2.0.post0 release has a known compatibility issue with the `sphinx_rtd_theme` (see the issue readthedocs/sphinx_rtd_theme#1343). Revert this commit once this compatibility issue is resolved. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
- A four-part version fails with sphinx_rtd_theme: readthedocs/sphinx_rtd_theme#1343 While this is a problem with sphinx_rtd_theme, the easiest solution is to limit Sphinx version (sphinx_rtd_theme updates *slowly*) - This should be reverted after either sphinx releases again with a more normal version number, or sphinx_rtd_theme updates. - Review: see if CI passes
Workaround in a project's requirements (as is being done by others in the references above):
It would be best if sphinx_rtd_theme releases with the fix in #1344, but another workaround is sphinx releasing with a 3-part version number. Or every project does the above, which is definitely not good. |
This patch temporarily restricts the Sphinx version since the latest one causes trouble with `sphinx_rtd_theme`. This should be reverted once that bug is fixed in the theme. See: readthedocs/sphinx_rtd_theme#1343
This patch temporarily restricts the Sphinx version since the latest one causes trouble with `sphinx_rtd_theme`. This should be reverted once that bug is fixed in the theme. See: readthedocs/sphinx_rtd_theme#1343
The sphinx doc build run by CircleCI is currently failing: ``` make: Entering directory '/home/circleci/wayback/docs' Traceback (most recent call last): File "/home/circleci/venv/bin/sphinx-build", line 5, in <module> from sphinx.cmd.build import main File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/cmd/build.py", line 25, in <module> from sphinx.application import Sphinx File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/application.py", line 42, in <module> from sphinx.registry import SphinxComponentRegistry File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/registry.py", line 24, in <module> from sphinx.builders import Builder File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 26, in <module> from sphinx.util import import_object, logging, rst, progress_message, status_iterator File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/util/rst.py", line 22, in <module> from jinja2 import environmentfilter ImportError: cannot import name 'environmentfilter' from 'jinja2' (/home/circleci/venv/lib/python3.8/site-packages/jinja2/__init__.py) make: *** [Makefile:20: html] Error 1 make: Leaving directory '/home/circleci/wayback/docs' Exited with code exit status 2 CircleCI ``` It looks like this might be the result of jinja2 imports being deprecated? sphinx-doc/sphinx#10291 I tried unpinning all the dependencies, and making a few minor changes to the sphinx config and the docs seem to build fine locally but maybe I'm missing some detail about theme/css? Unfortunately I did have to tell pip to ignore sphinx 5.2.0.post0 which appears to have a recent bug that hopefully will be fixed shortly: readthedocs/sphinx_rtd_theme#1343
The sphinx doc build run by CircleCI is currently failing: ``` make: Entering directory '/home/circleci/wayback/docs' Traceback (most recent call last): File "/home/circleci/venv/bin/sphinx-build", line 5, in <module> from sphinx.cmd.build import main File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/cmd/build.py", line 25, in <module> from sphinx.application import Sphinx File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/application.py", line 42, in <module> from sphinx.registry import SphinxComponentRegistry File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/registry.py", line 24, in <module> from sphinx.builders import Builder File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 26, in <module> from sphinx.util import import_object, logging, rst, progress_message, status_iterator File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/util/rst.py", line 22, in <module> from jinja2 import environmentfilter ImportError: cannot import name 'environmentfilter' from 'jinja2' (/home/circleci/venv/lib/python3.8/site-packages/jinja2/__init__.py) make: *** [Makefile:20: html] Error 1 make: Leaving directory '/home/circleci/wayback/docs' Exited with code exit status 2 CircleCI ``` It looks like this might be the result of jinja2 imports being deprecated? sphinx-doc/sphinx#10291 I tried unpinning all the dependencies, and making a few minor changes to the sphinx config and the docs seem to build fine locally but maybe I'm missing some detail about theme/css? Unfortunately I did have to tell pip to ignore sphinx 5.2.0.post0 which appears to have a recent bug that hopefully will be fixed shortly: readthedocs/sphinx_rtd_theme#1343
The sphinx doc build run by CircleCI is currently failing: ``` make: Entering directory '/home/circleci/wayback/docs' Traceback (most recent call last): File "/home/circleci/venv/bin/sphinx-build", line 5, in <module> from sphinx.cmd.build import main File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/cmd/build.py", line 25, in <module> from sphinx.application import Sphinx File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/application.py", line 42, in <module> from sphinx.registry import SphinxComponentRegistry File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/registry.py", line 24, in <module> from sphinx.builders import Builder File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 26, in <module> from sphinx.util import import_object, logging, rst, progress_message, status_iterator File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/util/rst.py", line 22, in <module> from jinja2 import environmentfilter ImportError: cannot import name 'environmentfilter' from 'jinja2' (/home/circleci/venv/lib/python3.8/site-packages/jinja2/__init__.py) make: *** [Makefile:20: html] Error 1 make: Leaving directory '/home/circleci/wayback/docs' Exited with code exit status 2 CircleCI ``` It looks like this might be the result of jinja2 imports being deprecated? sphinx-doc/sphinx#10291 I tried unpinning all the dependencies, and making a few minor changes to the sphinx config and the docs seem to build fine locally but maybe I'm missing some detail about theme/css? Unfortunately I did have to tell pip to ignore sphinx 5.2.0.post0 which appears to have a recent bug that hopefully will be fixed shortly: readthedocs/sphinx_rtd_theme#1343
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
This comment was marked as off-topic.
This comment was marked as off-topic.
Sphinx is pending a 5.2.1 release, this should resolve the issue (for now). |
Sphinx 5.2.0.post0 release has a known compatibility issue with the `sphinx_rtd_theme` (see the issue readthedocs/sphinx_rtd_theme#1343). Revert this commit once this compatibility issue is resolved. (cherry picked from commit f503847) Original-Signed-off-by: Stephanos Ioannidis <root@stephanos.io> GitOrigin-RevId: f503847 Change-Id: I20e1f285d8dec4eaf549cd55fe0df239a1afa8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/3916773 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: CopyBot Service Account <copybot.service@gmail.com> Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com>
I proposed a fix in #1345. |
This should be reverted once sphinx_rtd_theme is updated. See readthedocs/sphinx_rtd_theme#1343
This should be reverted once sphinx_rtd_theme is updated. See readthedocs/sphinx_rtd_theme#1343
this appears to have been caused by the latest sphinx being version
5.2.0.post0
https://github.com/pyca/cryptography/actions/runs/3119261059/jobs/5060248154
The text was updated successfully, but these errors were encountered: