Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1522: fix 'str' object has no attribute 'attributes' #1528

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Fix #1522: fix 'str' object has no attribute 'attributes' #1528

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b22a77f
Fix #1522: fix attribute error if css is str
leplatrem Sep 28, 2023
82ee56f
Revert "Fix #1522: fix attribute error if css is str"
humitos Oct 23, 2023
c4edd8b
Use `css_tag` only for standard CSS files from Sphinx
humitos Oct 23, 2023
94f173b
Normalize template variables
agjohnson Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions sphinx_rtd_theme/layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,13 @@
<link rel="stylesheet" href="{{ pathto('_static/' + style, 1) }}" type="text/css" />
<link rel="stylesheet" href="{{ pathto('_static/pygments.css', 1) }}" type="text/css" />
{%- endif %}
{%- for css in css_files %}
{{ css_tag(css) }}
{%- for css_file in css_files %}
{{ css_tag(css_file) }}
{%- endfor %}

{%- for cssfile in extra_css_files %}
{{ css_tag(cssfile) }}
{# "extra_css_files" is a theme option and it's always a string #}
{%- for css_file in extra_css_files %}
<link rel="stylesheet" href="{{ pathto(css_file, 1)|escape }}" type="text/css" />
{%- endfor -%}

{#- FAVICON
Expand Down