Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparison: Cloudflare Pages #229
Comparison: Cloudflare Pages #229
Changes from 2 commits
dc35f50
7221630
fb69e95
6bf858e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm, your suggestion is good. However, I'd like to keep "technical writers" somehow in the sentence because I want to rank on it --I put it there on purpose. We are not mentioning that role enough and we have been focusing us more in "developers" without reaching many technical writers.
Also, "Cloudflare pages is for frontend developers" is a concept that works great to me because the reader will immediately realize that Cloudflare is not for them. It's the way they sell themselves:
which makes sense since they allow creating some kind of APIs.
Also also, I'd like to leave the "documentation projects" as-is, since we already have customers documenting other type of projects that are not software. Like hardware, for example.
I'll take some parts of this suggestion. However, I'd really appreciate your thoughts here about my points to continue the conversation. After that, we can change this paragraph in a following PR 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I was mostly just trying to cleanup the language and couldn't find a good way to keep it in there, but fine with keeping it 👍