Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pricing: mention custom domain limitations #305

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Jun 27, 2024

We agreed on:

  • 2 domains per project on community
  • 5 domains per organization on Advanced
  • 15 domains per organization on Pro

This is the first step: update our pricing page for new customer. One of the next steps involves enforcing this in our application by adding Read the Docs features to the plans and also showing the domains left in the admin.

Related https://github.com/readthedocs/readthedocs-corporate/issues/1808


📚 Documentation preview 📚: https://readthedocs-about--305.org.readthedocs.build/

We agreed on:

- 2 domains per project on community
- 5 domains per organization on Advanced
- 15 domains per organization on Pro

This is the first step: update our pricing page for new customer.
One of the next steps involves enforcing this in our application by adding Read
the Docs features to the plans and also showing the domains left in the admin.

Related readthedocs/readthedocs-corporate#1808
@humitos humitos requested a review from a team as a code owner June 27, 2024 11:11
@@ -127,7 +128,7 @@ <h2 class="ui small monospace center aligned header">
{{ pricing.plan_feature("Concurrent builds", "2 concurrent builds", "fa-rectangle-vertical-history fa-swap-opacity") }}
{{ pricing.plan_feature("Public projects", "Host public documentation", "fa-globe") }}
{{ pricing.plan_feature("Public repositories", "Clone public repositories", "fa-globe") }}
{{ pricing.plan_feature("Custom domain", "Use your own domain", "fa-at") }}
{{ pricing.plan_feature("Custom domain", "2 custom domains", "fa-at") }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the number of projects using more than one domain on .org?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have 102 projects with more than 2 domains.

In [2]: Project.objects.annotate(n_domains=Count("domains")).filter(n_domains__gt=2).count()
Out[2]: 102

First 15 projects with many domains:

In [15]: list(Project.objects.annotate(n_domains=Count("domains")).filter(n_domains__gt=2).order_by("-n_domains")[:15].values_list("slug", flat=True))
Out[15]: 
['www',
 'readthedocs',
 'gooddal',
 'thiet-ke-web',
 'trevorbramwellnet',
 'astro-thesis',
 'stdlib-examples',
 'ompi',
 'zfsbootmenu',
 'python3info',
 'workshop-devops',
 'pirateweather',
 'astronaut-training-program',
 'jquantlib',
 'docoftheyear']

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I do think we want to add the domain count somewhere in the dashboard, though I feel like we need an "Organization status" page or something, but probably start on the Domains page for the project?

@humitos
Copy link
Member Author

humitos commented Jun 27, 2024

I do think we want to add the domain count somewhere in the dashboard, though I feel like we need an "Organization status" page or something

Yes, we want to this. It's also gonna be useful for the other pricing change we've been talking about regarding build time limits 👍🏼

but probably start on the Domains page for the project?

I'm not sure if we want to expose the number of domains used by the whole organization to project admins. However, I think we should add a form validation that fails if they ran out of domains saying they should talk to the organization owner. Then, the organization owner is the one that can access the "organization status" page and check these numbers.

Thoughts?

@ericholscher
Copy link
Member

I don't think it's a huge deal to expose the total number of domains, but I'm also fine just erroring on the validation as a starting point. We could even do something like "You have $x domains remaining" or similar, but I think it's also fine to just have a "Using 5/10 domains", it's not exposing any secrets.

@humitos
Copy link
Member Author

humitos commented Jul 3, 2024

I'm merging this PR, but I created another issue to track the changes on the domain/admin page to show the available ones and limit the creation if the limit is reached.

@humitos humitos merged commit 652947d into main Jul 3, 2024
5 checks passed
@humitos humitos deleted the humitos/pricing-custom-domains branch July 3, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants