[Java] Cluster interface config. #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeb01
reviewed
Feb 24, 2022
|
Is it possible to write a system test showing the interface configuration? Perhaps this could fall into the cluster topology tests? |
…r the dedicated channels or channel templates.
…oid an ad hoc channel creation and re-use the `interface` param and the `media` of the source channel.
… log Subscription.
…ion as this results in an exception being thrown, e.g. `java.lang.IllegalArgumentException: matching tag=35 has explicit endpoint or control: aeron:udp?tags=35,36|interface=10.42.0.0/24|control-mode=manual|session-id=-197116438|alias=log|group=true|rejoin=false <> aeron:udp?tags=35,36|interface=10.42.0.0/24|control-mode=manual|session-id=-197116438|alias=log|group=true|rejoin=false`.
vyazelenko
force-pushed
the
cluster-interface-config
branch
from
97b404d
to
5ddc89d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to configure
interfaceparams for all of the Cluster channels. To that end it:ChannelUri#createDestinationUri.aeron.cluster.follower.catchup.channelandaeron.cluster.leader.archive.control.channel. The former is used to create the replay channel when doing a catch up on the follower node. And the latter is used for creating a control request channel to the leader archive.egressChannelconfiguration option to theConsensusModulewhich is using the same configuration property as theAeronCluster(i.e.aeron.cluster.egress.channel). When theegressChannelis not defined then response channel from the leader to the client is based on theresponseChannelsent by the client. However if it defined then it is used a basis for the response channel, i.e. if the clientresponseChannelcontains anendpointparameter then it will be used to set/substitute the value in theegressChannelof the leader node and otherwise leader'segressChannelis used as is.