Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C] Fix aeron_mmap on Windows #865

Merged
merged 1 commit into from
Feb 20, 2020
Merged

[C] Fix aeron_mmap on Windows #865

merged 1 commit into from
Feb 20, 2020

Conversation

ltrzesniewski
Copy link
Contributor

  • Don't try to silently adjust the supplied length to the file size
  • off_t is 32 bits, so offset >> 32 generates a warning

Part of #863

@ltrzesniewski
[C] Fix aeron_mmap on Windows
5e482bd 
 - Don't try to silently adjust the supplied length to the file size
 - off_t is 32 bits, so offset >> 32 generates a warning
@mjpt777 mjpt777 merged commit 5cb2ebc into real-logic:master Feb 20, 2020
@ltrzesniewski ltrzesniewski deleted the winfix-mmap branch February 20, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltrzesniewski @mjpt777