Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferAlignmentException message misleading #130

Merged
merged 1 commit into from
Feb 27, 2018
Merged

BufferAlignmentException message misleading #130

merged 1 commit into from
Feb 27, 2018

Conversation

sebastien-doyon
Copy link
Contributor

BufferAlignmentException message always tell zero as the Buffer Alignment Offset

BufferAlignmentException message always tell zero as the Buffer Alignment Offset
@mjpt777 mjpt777 merged commit 89a6bfe into real-logic:master Feb 27, 2018
@sebastien-doyon sebastien-doyon deleted the patch-1 branch February 27, 2018 21:20
@mjpt777
Copy link
Contributor

mjpt777 commented Feb 27, 2018

There was a build failure on this. Please run the full build to check a PR. Thanks.

@sebastien-doyon sebastien-doyon restored the patch-1 branch February 27, 2018 22:07
@sebastien-doyon
Copy link
Contributor Author

@mjpt777 could you please provide the build error? I have done a full build locally that was successful.
By the way, I can also contribute a modified test that validate the exception message if you like.

@sebastien-doyon
Copy link
Contributor Author

@mjpt777 found your correction on a commit, thank you.

@mjpt777
Copy link
Contributor

mjpt777 commented Feb 27, 2018

The failure was a checkstyle validation. More useful tests are always great :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants