Fix syntactic_sugar

realm · Sep 30, 2022 · 4542647 · 4542647
1 parent 1186c21
commit 4542647
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 18 deletions.
diff --git a/Source/SwiftLintFramework/Rules/Idiomatic/SyntacticSugarRule.swift b/Source/SwiftLintFramework/Rules/Idiomatic/SyntacticSugarRule.swift
@@ -137,24 +137,6 @@ private final class SyntacticSugarRuleVisitor: SyntaxVisitor {
         }
     }
 
-    override func visitPost(_ node: AsExprSyntax) {
-        // json["recommendations"] as? ↓Array<[String: Any]>
-        if let violation = violation(in: node.typeName) {
-            violations.append(violation)
-        }
-    }
-
-    override func visitPost(_ node: UnresolvedAsExprSyntax) {
-        // json["recommendations"] as? ↓Array<[String: Any]>
-        if
-            let parent = node.parent,
-            let typeName = parent.children(viewMode: .sourceAccurate).last?.as(TypeExprSyntax.self),
-            let violation = violation(in: typeName.type)
-        {
-            violations.append(violation)
-        }
-    }
-
     override func visitPost(_ node: TypeInitializerClauseSyntax) {
         // typealias Document = ↓Dictionary<String, AnyBSON?>
         if let violation = violation(in: node.value) {
@@ -205,6 +187,12 @@ private final class SyntacticSugarRuleVisitor: SyntaxVisitor {
             .map { violations.append($0) }
     }
 
+    override func visitPost(_ node: TypeExprSyntax) {
+        if let violation = violation(in: node.type) {
+            violations.append(violation)
+        }
+    }
+
     private func violation(in typeSyntax: TypeSyntax?) -> SyntacticSugarRuleViolation? {
         if let optionalType = typeSyntax?.as(OptionalTypeSyntax.self) {
             return violation(in: optionalType.wrappedType)

diff --git a/Source/SwiftLintFramework/Rules/Idiomatic/SyntacticSugarRuleExamples.swift b/Source/SwiftLintFramework/Rules/Idiomatic/SyntacticSugarRuleExamples.swift
@@ -57,6 +57,11 @@ internal enum SyntacticSugarRuleExamples {
         Example("""
         @_specialize(where S == ↓Array<Character>)
         public init<S: Sequence>(_ elements: S)
+        """),
+
+        Example("""
+        let dict: [String: Any] = [:]
+        _ = dict["key"] as? ↓Optional<String?> ?? Optional<String?>.none
         """)
     ]