prefer contains over first(where:) != nil

realm · May 15, 2017 · 61e9b39 · 61e9b39
1 parent bb4c94b
commit 61e9b39
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Source/SwiftLintFramework/Rules/GenericTypeNameRule.swift b/Source/SwiftLintFramework/Rules/GenericTypeNameRule.swift
@@ -166,7 +166,7 @@ public struct GenericTypeNameRule: ASTRule, ConfigurationProviderRule {
             return []
         }
 
-        let containsAllowedSymbol = configuration.allowedSymbols.first(where: { name.contains($0) }) != nil
+        let containsAllowedSymbol = configuration.allowedSymbols.contains(where: name.contains)
         if !containsAllowedSymbol && !CharacterSet.alphanumerics.isSuperset(ofCharactersIn: name) {
             return [
                 StyleViolation(ruleDescription: type(of: self).description,

diff --git a/Source/SwiftLintFramework/Rules/IdentifierNameRule.swift b/Source/SwiftLintFramework/Rules/IdentifierNameRule.swift
@@ -47,7 +47,7 @@ public struct IdentifierNameRule: ASTRule, ConfigurationProviderRule {
 
             let type = self.type(for: kind)
             if !isFunction {
-                let containsAllowedSymbol = configuration.allowedSymbols.first(where: { name.contains($0) }) != nil
+                let containsAllowedSymbol = configuration.allowedSymbols.contains(where: name.contains)
                 if !containsAllowedSymbol &&
                     !CharacterSet.alphanumerics.isSuperset(ofCharactersIn: name) {
                     return [

diff --git a/Source/SwiftLintFramework/Rules/TypeNameRule.swift b/Source/SwiftLintFramework/Rules/TypeNameRule.swift
@@ -74,7 +74,7 @@ public struct TypeNameRule: ASTRule, ConfigurationProviderRule {
         }
 
         let name = name.nameStrippingLeadingUnderscoreIfPrivate(dictionary)
-        let containsAllowedSymbol = configuration.allowedSymbols.first(where: { name.contains($0) }) != nil
+        let containsAllowedSymbol = configuration.allowedSymbols.contains(where: name.contains)
         if !containsAllowedSymbol && !CharacterSet.alphanumerics.isSuperset(ofCharactersIn: name) {
             return [StyleViolation(ruleDescription: type(of: self).description,
                severity: .error,