False positive implicit_getter violation when mentioning word "set" in a comment in custom getter of a read-write var

[yas375]

New Issue Checklist

• Updated SwiftLint to the latest version
• I searched for existing GitHub issues

Describe the bug

Mentioning word "set" (without parentheses) in a comment in a get of a read-write var with both get and set defined triggers SwiftLint to think that this is a read-only property.

Complete output when running SwiftLint, including the stack trace and command used

$ swiftlint lint --path Test.swift --no-cache --enable-all-rules
Loading configuration from '.swiftlint.yml'
Linting Swift files at paths Test.swift
Linting 'Test.swift' (1/1)
/Users/yas/code/caremobile/Test.swift:3:9: warning: Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)
Done linting! Found 1 violation, 0 serious in 1 file.

Environment

• SwiftLint 0.39.1
• Installation method used: Homebrew
• Paste your configuration file:

excluded:
  - Pods

opt_in_rules:
  - array_init
  - contains_over_first_not_nil
  - collection_alignment
  - contains_over_filter_count
  - empty_count
  - empty_collection_literal
  - overridden_super_call
  - sorted_first_last
  - yoda_condition

disabled_rules:
  - cyclomatic_complexity
  - file_length
  - force_cast
  - force_try
  - function_body_length
  - function_parameter_count
  - identifier_name
  - large_tuple
  - line_length
  - multiple_closures_with_trailing_closure
  - nesting # consider
  - notification_center_detachment
  - operator_whitespace
  - todo # fix
  - type_body_length
  - type_name # consider
  - weak_delegate # fix

statement_position:
  statement_mode: uncuddled_else

• Are you using nested configurations?No

• Which Xcode version are you using (check xcodebuild -version)?
  Xcode 11.4
  Build version 11E146

• Do you have a sample that shows the issue?
  Yes:

Test.swift

extension Test {
    var foo: Bool {
        get {
            bar?.boolValue ?? true // Comment mentioning word set which triggers violation
        }
        set {
            bar = NSNumber(value: newValue as Bool)
        }
    }
}

If I don't mention word "set" in the comment then it seem to work fine.
I don't recall seeing this issues prior to updating to Xcode 11.4.

Hope it helps.

[freak4pc]

Pretty sure this fixes it?
#3099

[yas375]

Oh, thanks. I somehow missed that PR during my search for existing reports.
Based on the description I guess it is indeed supposed to fix this issue... But I'm running current SwiftLint version (0.39.1), which includes that fix, and I'm still getting the issue. So perhaps there is something else needs to be done. Maybe something around swift version check? Not sure...

[freak4pc]

It doesn’t include that fix IMO

[freak4pc]

0.39.1 is almost two months old,
I imagine they’ll accumulate some content and release 0.40 soon

[yas375]

From what I see, 0.39.1 already includes that code (4e84992):
https://github.com/realm/SwiftLint/blob/0.39.1/Source/SwiftLintFramework/Rules/Style/ImplicitGetterRule.swift#L29-L51

[p4checo]

It's also triggering a false positive if we have both a get and a nonmutating set:

extension Reactive where Base: UITapGestureRecognizer {

    var tapped: CocoaAction<Base>? {
        get {
            return associatedAction.withValue { $0.flatMap { $0.action } }
        }

        nonmutating set {
            setAction(newValue)
        }
    }
}

[mkj-is]

I found another false-positive. When the set is before the get you get warning. If it is the other way round then everything is all right. I believe another rule could be created to formalize the order of get-set.

extension Float {
    var clamped: Float {
        set {
            self = min(1, max(0, newValue))
        }
        get {
            min(1, max(0, self))
        }
    }
}

Command:

swiftlint

Output:

Linting Swift files at paths 
Linting 'lint.swift' (1/1)
/Users/kaspar/Downloads/swiftlint-issue/lint.swift:6:9: warning: Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)
Done linting! Found 1 violation, 0 serious in 1 file.

[yas375]

@marcelofabri thanks a lot!

[marcelofabri]

thanks for everyone reporting different minimal examples! this has been very helpful to fix the issue quickly

[freak4pc]

Not sure if this fits in the same fix:

[tahirmt]

Which release is this going to and when?

[jpsim]

The fix will go in the next release, either 0.39.2 or 0.40.0, depending on how we choose to version it. That’ll be in the next few days probably. Depends on if we think we can get more Swift 5.2 fixes in time.

[jpsim]

@freak4pc can you see if the latest commit from master fixes that for you?

[nicolas-miari]

Looking forward to the fixing release. My code below still triggers this false positive on 0.39.1:

import Foundation

extension UserDefaults {
    var didShowWelcomeWindow: Bool {
        set {
            self.set(newValue, forKey: "didShowWelcomeWindow")
        }
        get {
            return bool(forKey: "didShowWelcomeWindow")
        }
    }
}

Update: it resolves if I move the getter above the setter:

var didShowWelcomeWindow: Bool {
    get {
        return bool(forKey: "didShowWelcomeWindow”)
    }
    set {
        self.set(newValue, forKey: "didShowWelcomeWindow”)
    }    
}

[ahmedsafadii]

no fix ?

[freak4pc]

@jpsim my issues are fixed on the last master

[kb100824]

u need find file : .swiftlint.yml , then just do it

disabled_rules: 
  - implicit_getter