Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives for force_unwrapping in 0.9.1 #547

Closed
brandenr opened this issue Feb 17, 2016 · 8 comments
Closed

False positives for force_unwrapping in 0.9.1 #547

brandenr opened this issue Feb 17, 2016 · 8 comments
Labels
bug Unexpected and reproducible misbehavior.

Comments

@brandenr
Copy link

These three lines are getting caught as force_unwrapping, though they're not force unwrapping:

setEditing(!editing, animated: true)

navigationController.setNavigationBarHidden(!navigationController.navigationBarHidden, animated: true)

if addedToPlaylist && (!self.selectedFilters.isEmpty || self.searchBar?.text?.isEmpty == false) {

@norio-nomura norio-nomura added the bug Unexpected and reproducible misbehavior. label Feb 17, 2016
@stephanheilner
Copy link

👍

@norio-nomura
Copy link
Collaborator

I opened PR #552 for fixing the issue #546, #547.
Feedback is welcome.

@jpsim
Copy link
Collaborator

jpsim commented Mar 10, 2016

Fixed by @norio-nomura! 🎉

@jpsim jpsim closed this as completed Mar 10, 2016
@brandenr
Copy link
Author

Any ETA for a release of this fix?

@jpsim
Copy link
Collaborator

jpsim commented Mar 15, 2016

I'll cut a release shortly since we haven't done one in about a month and there have been a handful of bug fixes made since.

@brandenr
Copy link
Author

Could you also push it to brew, please?

@jpsim
Copy link
Collaborator

jpsim commented Mar 16, 2016

@brandenr
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected and reproducible misbehavior.
Projects
None yet
Development

No branches or pull requests

4 participants