Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --lenient #1359

Closed
wants to merge 37 commits into from
Closed

add --lenient #1359

wants to merge 37 commits into from

Conversation

aaroncrespo
Copy link
Contributor

No description provided.

@aaroncrespo
Copy link
Contributor Author

Don't worry about un-verified I did this on a computer missing my gpg. key.

@aaroncrespo aaroncrespo changed the title Lenient add --lenient Mar 15, 2017
@aaroncrespo
Copy link
Contributor Author

re: #1322

@SwiftLintBot
Copy link

SwiftLintBot commented Mar 15, 2017

1 Warning
⚠️ Permanently added the RSA host key for IP address ‘192.30.253.112’ to the list of known hosts.
12 Messages
📖 Linting WordPress-iOS with this PR took 16.05s vs 17.14s on master (6% faster)
📖 Linting swift with this PR took 14.53s vs 14.36s on master (1% slower)
📖 Linting Aerial with this PR took 0.55s vs 0.54s on master (1% slower)
📖 Linting SourceKitten with this PR took 1.52s vs 1.58s on master (3% faster)
📖 Linting Sourcery with this PR took 3.55s vs 3.58s on master (0% faster)
📖 Linting ios-oss with this PR took 21.4s vs 21.76s on master (1% faster)
📖 Linting Alamofire with this PR took 4.18s vs 4.08s on master (2% slower)
📖 Linting firefox-ios with this PR took 22.98s vs 23.46s on master (2% faster)
📖 Linting Nimble with this PR took 2.38s vs 2.48s on master (4% faster)
📖 Linting Quick with this PR took 0.7s vs 0.72s on master (2% faster)
📖 Linting realm-cocoa with this PR took 3.63s vs 3.89s on master (6% faster)
📖 Linting Moya with this PR took 0.54s vs 0.55s on master (1% faster)

Generated by 🚫 danger

@aaroncrespo
Copy link
Contributor Author

CI Is failing because type checking something took 190ms over the 150ms max.

@aaroncrespo
Copy link
Contributor Author

Not sure what to do next the failures seem unrelated to the changes in this PR.

@marcelofabri
Copy link
Collaborator

I think the issue was more about using warnings (and never errors) than the return code.

@aaroncrespo
Copy link
Contributor Author

I've updated the PR:

  • convert any error violations to warning violations. I couldn't see an approach that was much different than what I did outside of parameterizing the option to all sorts of types.
  • then if lenient is set, I suppress any warning threshold error

@marcelofabri
Copy link
Collaborator

Integrations tests are failing, can you please take a look at this?

@aaroncrespo
Copy link
Contributor Author

going to resubmit I think a squash failed.

@aaroncrespo aaroncrespo deleted the lenient branch March 18, 2017 21:18
@codecov-io
Copy link

Codecov Report

Merging #1359 into master will decrease coverage by 0.07%.
The diff coverage is 53.48%.

@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
- Coverage   81.89%   81.82%   -0.08%     
==========================================
  Files         175      176       +1     
  Lines        8898     8934      +36     
==========================================
+ Hits         7287     7310      +23     
- Misses       1611     1624      +13
Impacted Files Coverage Δ
...rce/SwiftLintFramework/Models/MasterRuleList.swift 100% <ø> (ø) ⬆️
Source/swiftlint/Commands/LintCommand.swift 0% <0%> (ø) ⬆️
Tests/SwiftLintFrameworkTests/RulesTests.swift 71.81% <66.66%> (-0.07%) ⬇️
...intFramework/Rules/ExplicitTypeInterfaceRule.swift 91.3% <91.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80c3050...c521493. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants