Improve for_where rule

[marcelofabri]

Fixes #1387

[SwiftLintBot]

	1 Warning
⚠️	This PR may need tests.

	20 Messages
📖	Linting WordPress-iOS with this PR took 17.71s vs 19.08s on master (7% faster)
📖	This PR fixed a violation in swift: /stdlib/public/SDK/Foundation/Data.swift#L1292:13: warning: For Where Violation: where clauses are preferred over a single if inside a for. (for_where)
📖	This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift#L253:13: warning: For Where Violation: where clauses are preferred over a single if inside a for. (for_where)
📖	This PR fixed a violation in firefox-ios: /Sync/SyncStateMachine.swift#L611:17: warning: For Where Violation: where clauses are preferred over a single if inside a for. (for_where)
📖	This PR fixed a violation in Nimble: /Tests/NimbleTests/Helpers/utils.swift#L19:13: warning: For Where Violation: where clauses are preferred over a single if inside a for. (for_where)
📖	This PR fixed a violation in WordPress-iOS: /WordPress/Classes/Utility/WPImageURLHelper.swift#L23:17: warning: For Where Violation: where clauses are preferred over a single if inside a for. (for_where)
📖	This PR fixed a violation in WordPress-iOS: /WordPress/Classes/ViewRelated/Blog/SharingAccountViewController.swift#L224:13: warning: For Where Violation: where clauses are preferred over a single if inside a for. (for_where)
📖	This PR fixed a violation in WordPress-iOS: /WordPress/Classes/ViewRelated/Post/AztecPostViewController.swift#L2072:13: warning: For Where Violation: where clauses are preferred over a single if inside a for. (for_where)
📖	Linting Alamofire with this PR took 4.56s vs 4.48s on master (1% slower)
📖	Linting swift with this PR took 15.8s vs 15.54s on master (1% slower)
📖	This PR fixed a violation in swift: /stdlib/public/core/Character.swift#L229:7: warning: For Where Violation: where clauses are preferred over a single if inside a for. (for_where)
📖	Linting SourceKitten with this PR took 1.68s vs 1.75s on master (4% faster)
📖	Linting Sourcery with this PR took 3.95s vs 4.14s on master (4% faster)
📖	Linting ios-oss with this PR took 24.57s vs 25.82s on master (4% faster)
📖	Linting Moya with this PR took 0.57s vs 0.61s on master (6% faster)
📖	Linting firefox-ios with this PR took 25.19s vs 26.74s on master (5% faster)
📖	Linting Nimble with this PR took 2.33s vs 2.45s on master (4% faster)
📖	Linting Quick with this PR took 0.74s vs 0.75s on master (1% faster)
📖	Linting realm-cocoa with this PR took 3.87s vs 3.96s on master (2% faster)
📖	Linting Aerial with this PR took 0.55s vs 0.56s on master (1% faster)

Generated by 🚫 danger

[codecov-io]

Codecov Report

Merging #1393 into master will increase coverage by 0.02%.
The diff coverage is 92.3%.

@@            Coverage Diff             @@
##           master    #1393      +/-   ##
==========================================
+ Coverage    81.8%   81.82%   +0.02%     
==========================================
  Files         181      181              
  Lines        9089     9112      +23     
==========================================
+ Hits         7435     7456      +21     
- Misses       1654     1656       +2

Impacted Files	Coverage Δ
Source/SwiftLintFramework/Rules/ForWhereRule.swift	93.65% <92.3%> (-1.35%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b2c5b...802a7dd. Read the comment docs.

[jpsim]

Awesome 👍