Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in empty_enum_arguments rule #1560

Merged
merged 2 commits into from
May 25, 2017
Merged

Fix false positive in empty_enum_arguments rule #1560

merged 2 commits into from
May 25, 2017

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1549

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.37s vs 0.38s on master (2% faster)
📖 Linting Alamofire with this PR took 2.31s vs 2.34s on master (1% faster)
📖 Linting Firefox with this PR took 9.85s vs 9.99s on master (1% faster)
📖 Linting Kickstarter with this PR took 12.85s vs 13.19s on master (2% faster)
📖 Linting Moya with this PR took 0.31s vs 0.33s on master (6% faster)
📖 Linting Nimble with this PR took 1.29s vs 1.31s on master (1% faster)
📖 Linting Quick with this PR took 0.43s vs 0.47s on master (8% faster)
📖 Linting Realm with this PR took 1.97s vs 2.06s on master (4% faster)
📖 Linting SourceKitten with this PR took 0.85s vs 0.87s on master (2% faster)
📖 Linting Sourcery with this PR took 2.05s vs 2.13s on master (3% faster)
📖 Linting Swift with this PR took 9.16s vs 9.39s on master (2% faster)
📖 Linting WordPress with this PR took 9.5s vs 9.69s on master (1% faster)

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #1560 into master will increase coverage by 0.01%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1560      +/-   ##
==========================================
+ Coverage   84.25%   84.26%   +0.01%     
==========================================
  Files         191      191              
  Lines        9950     9949       -1     
==========================================
+ Hits         8383     8384       +1     
+ Misses       1567     1565       -2
Impacted Files Coverage Δ
...SwiftLintFramework/Rules/GenericTypeNameRule.swift 93.54% <0%> (-0.11%) ⬇️
...iftLintFramework/Rules/ShorthandOperatorRule.swift 85.29% <100%> (-0.43%) ⬇️
...e/SwiftLintFramework/Rules/TrailingCommaRule.swift 95.14% <100%> (ø) ⬆️
...LintFramework/Extensions/SyntaxMap+SwiftLint.swift 100% <100%> (ø) ⬆️
...e/SwiftLintFramework/Rules/ObjectLiteralRule.swift 96.07% <100%> (ø) ⬆️
...iftLintFramework/Rules/StatementPositionRule.swift 96.19% <100%> (-0.04%) ⬇️
...tFramework/Rules/OperatorUsageWhitespaceRule.swift 95.34% <100%> (ø) ⬆️
...ftLintFramework/Rules/EmptyEnumArgumentsRule.swift 96.42% <100%> (+3.83%) ⬆️
...ftLintFramework/Rules/VerticalWhitespaceRule.swift 95.6% <100%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66c060d...fd5ce1c. Read the comment docs.

@marcelofabri marcelofabri merged commit c2e4c9b into realm:master May 25, 2017
@marcelofabri marcelofabri deleted the bugfix-1549 branch May 25, 2017 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants