Add --use-script-input-files #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Option to lint files provided by `SCRIPT_INPUT_FILE_*` environment variables
|
This is great, @norio-nomura! I like the Xcode plugin too! Thanks for the PR 🎉 |
|
😄 |
|
nice! |
norio-nomura
added a commit
to norio-nomura/SwiftLint
that referenced
this pull request
Nov 18, 2015
…NG.md It was missing on realm#193.
norio-nomura
added a commit
to norio-nomura/SwiftLint
that referenced
this pull request
Nov 18, 2015
…G.md It was missing on realm#193.
norio-nomura
added a commit
to norio-nomura/SwiftLint
that referenced
this pull request
Nov 18, 2015
…G.md It was missing on realm#193.
norio-nomura
added a commit
to norio-nomura/SwiftLint
that referenced
this pull request
Nov 18, 2015
…NG.md It was missing on realm#193.
jpsim
added a commit
that referenced
this pull request
Nov 21, 2015
Add a summary of #193 to CHANGELOG.md by following to CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option to lint files provided by
SCRIPT_INPUT_FILE_*environment variables.I created a Xcode plugin "ExtraBuildPhase" that runs SwiftLint on every building without adding "Run Script" build phase to targets in Xcode Project.
I want to resolve a problem that on running SwiftLint by ExtraBuildPhase.
When ExtraBuildPhase runs SwiftLint on each target, SwiftLint does lint all source files under the Project directory. That cause every sources are been lint multiple time as number of targets in Project. 😞
For resolving this problem, I added functionality to ExtraBuildPhase that provide SourceBuildPhase targets(source files) by
SCRIPT_INPUT_FILE_*environment variables to shell script for running SwiftLint.https://github.com/norio-nomura/ExtraBuildPhase/releases/tag/0.3
By applying this PR and using
--use-script-input-files, SwiftLint does lint only sources that builded by target on Xcode with ExtraBuildPhase.You can try swiftlint-use-script-input-files branch of ExtraBuildPhase that enabled using
--use-script-input-filesoption by default.Thanks,