Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives in for_where with pattern matching #1978

Merged
merged 1 commit into from
Dec 20, 2017

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1968

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.45s vs 0.39s on master (15% slower)
📖 Linting Alamofire with this PR took 3.42s vs 3.26s on master (4% slower)
📖 Linting Firefox with this PR took 13.11s vs 13.46s on master (2% faster)
📖 Linting Kickstarter with this PR took 20.38s vs 21.07s on master (3% faster)
📖 Linting Moya with this PR took 1.77s vs 1.86s on master (4% faster)
📖 Linting Nimble with this PR took 1.89s vs 1.98s on master (4% faster)
📖 Linting Quick with this PR took 0.55s vs 0.58s on master (5% faster)
📖 Linting Realm with this PR took 3.43s vs 3.61s on master (4% faster)
📖 Linting SourceKitten with this PR took 1.13s vs 1.15s on master (1% faster)
📖 Linting Sourcery with this PR took 4.6s vs 4.75s on master (3% faster)
📖 Linting Swift with this PR took 14.74s vs 14.95s on master (1% faster)
📖 Linting WordPress with this PR took 13.76s vs 13.84s on master (0% faster)

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #1978 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1978   +/-   ##
=======================================
  Coverage   89.62%   89.62%           
=======================================
  Files         246      246           
  Lines       14390    14390           
  Branches      923      923           
=======================================
  Hits        12897    12897           
  Misses       1479     1479           
  Partials       14       14
Impacted Files Coverage Δ
Source/SwiftLintFramework/Rules/ForWhereRule.swift 94.52% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 755f3ad...c1da2bd. Read the comment docs.

@marcelofabri marcelofabri merged commit fc61e01 into master Dec 20, 2017
@marcelofabri marcelofabri deleted the mf-for-where-case branch December 20, 2017 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants