Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enclosedSwiftAttributes in Swift 4.1 #2020

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Fix enclosedSwiftAttributes in Swift 4.1 #2020

merged 1 commit into from
Jan 25, 2018

Conversation

marcelofabri
Copy link
Collaborator

Fixes #2019

key.attributes now contains key.offset and key.length, which are numbers.

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.44s vs 0.4s on master (9% slower)
📖 Linting Alamofire with this PR took 3.36s vs 3.3s on master (1% slower)
📖 Linting Firefox with this PR took 13.1s vs 12.98s on master (0% slower)
📖 Linting Kickstarter with this PR took 20.44s vs 20.61s on master (0% faster)
📖 Linting Moya with this PR took 1.83s vs 1.8s on master (1% slower)
📖 Linting Nimble with this PR took 1.94s vs 1.92s on master (1% slower)
📖 Linting Quick with this PR took 0.55s vs 0.57s on master (3% faster)
📖 Linting Realm with this PR took 3.62s vs 3.56s on master (1% slower)
📖 Linting SourceKitten with this PR took 1.1s vs 1.13s on master (2% faster)
📖 Linting Sourcery with this PR took 4.88s vs 5.03s on master (2% faster)
📖 Linting Swift with this PR took 13.81s vs 14.55s on master (5% faster)
📖 Linting WordPress with this PR took 14.93s vs 15.39s on master (2% faster)

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #2020 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2020      +/-   ##
==========================================
+ Coverage   89.65%   89.66%   +<.01%     
==========================================
  Files         254      254              
  Lines       14862    14862              
  Branches      967      967              
==========================================
+ Hits        13325    13326       +1     
+ Misses       1519     1518       -1     
  Partials       18       18
Impacted Files Coverage Δ
...intFramework/Extensions/Dictionary+SwiftLint.swift 85.71% <100%> (+0.14%) ⬆️
...SwiftLintFramework/Extensions/File+SwiftLint.swift 95.11% <0%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 203d243...19edf26. Read the comment docs.

@marcelofabri marcelofabri merged commit 0105b1c into realm:master Jan 25, 2018
@marcelofabri marcelofabri deleted the enclosedSwiftAttributes-4.1 branch January 25, 2018 18:21
@Coeur
Copy link

Coeur commented Jan 30, 2018

Oh please release it soon. :)
I have to disable SwiftLint with Xcode 9.3 in the mean time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants